SnTrade changelog

Changes

Hardening from the fifth full audit (0 critical findings; these are warning-level fixes).

• Value-incident cleanup: a graceful server stop with a live trade no longer leaves false INCIDENT files for the next boot. Cursor-rescue and take-back records are cleared when their claim commits after the player quit.
• Reload: /trade reload after editing server-name keeps the running name (console warning: rename with a restart) and still applies every other setting. Before, the whole reload was dropped.
• EdTools: a credit to a currency id EdTools no longer serves is refused, so the money stays owed as a claim instead of counting as delivered.
• MySQL scope.id: written through a forced temp file and a no-replace move, so a crash on the first boot cannot leave an empty identity file.
• Claims and history: refused with a message while trading. A failed database read now tells the player (new lang key messages.read-failed). A cancelled unrelated inventory open no longer drops the pending menu.
• Messages: the chat amount prompt names the configured cancel-words (new {cancel} placeholder); the request cooldown no longer shows 0s; lock/unlock confirmations reach the admin and staff even after a slow database write.
• Anvil prompt: guards InventoryOpenEvent#titleOverride on Paper builds older than 1.20.2.
• Failure logging for the boot crash-journal scan and the join claims notice; config, GUI and Javadoc comment corrections.

Upgrade notes

• New lang key messages.read-failed merges automatically. Existing lang/messages_*.yml files keep their current input-chat-prompt text; add {cancel} there by hand if you want the configured words shown.

Known limitations

• Trades ended by a death (and every trade with save-player-data-on-complete: false) still keep their value-incident files until removed by hand.
• EdTools add/remove timing and unknown-id behavior are not documented upstream; credits are guarded, not re-read.
• No live Paper, MySQL, Vault or EdTools run was part of this audit.

First stable release of SnTrade: secure player-to-player trading of items and Vault / EdTools currencies, built on SnLib.

Requirements: Paper 1.20.4 to 1.21.x, SnLib, the Sn bundle license key. Vault and EdTools are optional.

Highlights

• Escrow model: offered items leave the inventory, menus show marked display copies, every offer re-reads the real slot or cursor.
• One-step settlement on the main thread with full rollback; a provider refusal that moved nothing rolls back cleanly, an uncertain money move is logged as an INCIDENT and never compensated automatically.
• Claims mailbox (/trade claims): nothing hits the ground by default.
• Crash journal and local value-incident records for staff review (/trade recover), never an automatic restore.
• Network-safe MySQL: per server-name scope lease with SQL fencing, fail-closed pauses, server and network trade locks.
• New config key cooldowns.offer-click-millis (default 100, minimum 50) bounds offer and take-back writes per trader.

Audit: final Sn audit gate PASSED (all criticals blind verified, final independent close pass clean). Not yet boot-tested on a live server; run a dev-server boot first.